diff options
author | Chen-Yu Tsai <wens@csie.org> | 2016-07-22 18:16:10 +0800 |
---|---|---|
committer | Hans de Goede <hdegoede@redhat.com> | 2016-07-26 21:56:03 +0200 |
commit | a85ba87dbe24816f2119e7475e255cc08b30934b (patch) | |
tree | a540e0fd0f3cb8d2809e6927320e7c7772a0555b /include/dp83848.h | |
parent | 687284483c15b569da25f4727b3449e1e1d0dc17 (diff) | |
download | u-boot-imx-a85ba87dbe24816f2119e7475e255cc08b30934b.zip u-boot-imx-a85ba87dbe24816f2119e7475e255cc08b30934b.tar.gz u-boot-imx-a85ba87dbe24816f2119e7475e255cc08b30934b.tar.bz2 |
net: sun8i_emac: Drop redundant and incorrect setting of syscon register
In sun8i_emac_board_setup, the driver partially configures the syscon
register for H3 EPHY. However, the settings are incomplete, and
completely unusable. The correct settings are later set in
sun8i_emac_set_syscon, but the incorrect CLK_SEL setting persists.
It is incorrect to use CLK_SEL to select 25 MHz, as the SoC does not
have a 25 MHz clock the EPHY can use.
This patch removes the setting of the syscon register in board_setup,
and also moves set_syscon above mdio_init. While mdio_init does not
access the PHY, it is better to have the PHY parameters setup before
the MDIO bus is registered.
Fixes: a29710c525ff ("net: Add EMAC driver for H3/A83T/A64 SoCs.")
Signed-off-by: Chen-Yu Tsai <wens@csie.org>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Diffstat (limited to 'include/dp83848.h')
0 files changed, 0 insertions, 0 deletions