diff options
| author | Wolfgang Denk <wd@denx.de> | 2011-02-11 12:25:48 +0000 |
|---|---|---|
| committer | Albert Aribaud <albert.aribaud@free.fr> | 2011-02-21 08:30:55 +0100 |
| commit | 495df3bad9f250a36470cce15f14c36c616172b6 (patch) | |
| tree | cb5c1c1f3a4aab72b37538b527096fea076c3def /board | |
| parent | 6087f1a90cb2f275752496229b96f0e00aa0a7cd (diff) | |
| download | u-boot-imx-495df3bad9f250a36470cce15f14c36c616172b6.zip u-boot-imx-495df3bad9f250a36470cce15f14c36c616172b6.tar.gz u-boot-imx-495df3bad9f250a36470cce15f14c36c616172b6.tar.bz2 | |
ARM: fix write*() I/O accessors
Commit 3c0659b "ARM: Avoid compiler optimization for readb, writeb
and friends." introduced I/O accessors with memory barriers.
Unfortunately the new write*() accessors introduced a bug:
The problem is that the argument "v" gets evaluated twice. This
breaks code like used here (from "drivers/net/dnet.c"):
for (i = 0; i < wrsz; i++)
writel(*bufp++, &dnet->regs->TX_DATA_FIFO);
Use auxiliary variables to avoid such problems.
Signed-off-by: Wolfgang Denk <wd@denx.de>
Cc: Albert Aribaud <albert.aribaud@free.fr>
Cc: Alexander Holler <holler@ahsoftware.de>
Cc: Dirk Behme <dirk.behme@googlemail.com>
Diffstat (limited to 'board')
0 files changed, 0 insertions, 0 deletions