summaryrefslogtreecommitdiff
path: root/board/freescale/mpc8315erdb/mpc8315erdb.c
diff options
context:
space:
mode:
authorAnton Vorontsov <avorontsov@ru.mvista.com>2008-07-10 17:20:51 +0400
committerKim Phillips <kim.phillips@freescale.com>2008-07-16 14:16:44 -0500
commit021f6df6e96af5b387810cf96d24848da1faa55c (patch)
tree95607c6bc5b38d41233690a3165dd2e1f1f117a6 /board/freescale/mpc8315erdb/mpc8315erdb.c
parent25f5f0d49a3ae89bf4396f2557ce98debfef21da (diff)
downloadu-boot-imx-021f6df6e96af5b387810cf96d24848da1faa55c.zip
u-boot-imx-021f6df6e96af5b387810cf96d24848da1faa55c.tar.gz
u-boot-imx-021f6df6e96af5b387810cf96d24848da1faa55c.tar.bz2
83xx: mpc8315erdb: fix silly thinko in fdt_tsec1_fixup
The thinko was quite silly indeed, I messed with !ptr. Normally this would trigger some fault, but in U-Boot NULL pointer is equal to phys 0, so the code was working still, just didn't actually test mpc8315erdb environment variable value. Heh. Signed-off-by: Anton Vorontsov <avorontsov@ru.mvista.com> Signed-off-by: Kim Phillips <kim.phillips@freescale.com>
Diffstat (limited to 'board/freescale/mpc8315erdb/mpc8315erdb.c')
-rw-r--r--board/freescale/mpc8315erdb/mpc8315erdb.c19
1 files changed, 10 insertions, 9 deletions
diff --git a/board/freescale/mpc8315erdb/mpc8315erdb.c b/board/freescale/mpc8315erdb/mpc8315erdb.c
index 7555ffb..3eecee2 100644
--- a/board/freescale/mpc8315erdb/mpc8315erdb.c
+++ b/board/freescale/mpc8315erdb/mpc8315erdb.c
@@ -128,15 +128,16 @@ void fdt_tsec1_fixup(void *fdt, bd_t *bd)
const char *path;
int ret;
- if (!mpc8315erdb) {
- if (!strcmp(mpc8315erdb, "tsec1")) {
- return;
- } else if (strcmp(mpc8315erdb, "ulpi")) {
- printf("WARNING: wrong `mpc8315erdb' environment "
- "variable specified: `%s'. Should be `ulpi' "
- "or `tsec1'.\n", mpc8315erdb);
- return;
- }
+ if (!mpc8315erdb)
+ return;
+
+ if (!strcmp(mpc8315erdb, "tsec1")) {
+ return;
+ } else if (strcmp(mpc8315erdb, "ulpi")) {
+ printf("WARNING: wrong `mpc8315erdb' environment "
+ "variable specified: `%s'. Should be `ulpi' "
+ "or `tsec1'.\n", mpc8315erdb);
+ return;
}
ret = fdt_path_offset(fdt, "/aliases");