summaryrefslogtreecommitdiff
path: root/arch/sandbox
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2014-11-11 12:47:08 -0700
committerSimon Glass <sjg@chromium.org>2014-11-26 20:25:39 -0700
commitf80a8bbee8665defb32f26029325667704bb4776 (patch)
treea91330fe6cc6b6ecc724e581dd329cc2e336d452 /arch/sandbox
parente48f3741c357246c78aa367bbd56fe2684f7bf8d (diff)
downloadu-boot-imx-f80a8bbee8665defb32f26029325667704bb4776.zip
u-boot-imx-f80a8bbee8665defb32f26029325667704bb4776.tar.gz
u-boot-imx-f80a8bbee8665defb32f26029325667704bb4776.tar.bz2
sandbox: Fix warnings in cpu.c and os.c
This fixes the following two problems: cppcheck reports: [arch/sandbox/cpu/start.c:132]: (error) Uninitialized variable: err [arch/sandbox/cpu/os.c:371]: (error) Memory leak: fname Signed-off-by: Simon Glass <sjg@chromium.org> Reported-by: Wolfgang Denk <wd@denx.de>
Diffstat (limited to 'arch/sandbox')
-rw-r--r--arch/sandbox/cpu/os.c1
-rw-r--r--arch/sandbox/cpu/start.c3
2 files changed, 3 insertions, 1 deletions
diff --git a/arch/sandbox/cpu/os.c b/arch/sandbox/cpu/os.c
index 31c9344..4d5f805 100644
--- a/arch/sandbox/cpu/os.c
+++ b/arch/sandbox/cpu/os.c
@@ -367,6 +367,7 @@ int os_dirent_ls(const char *dirname, struct os_dirent_node **headp)
done:
closedir(dir);
+ free(fname);
return ret;
}
diff --git a/arch/sandbox/cpu/start.c b/arch/sandbox/cpu/start.c
index 0df7770..42353d8 100644
--- a/arch/sandbox/cpu/start.c
+++ b/arch/sandbox/cpu/start.c
@@ -130,7 +130,8 @@ static int sandbox_cmdline_cb_memory(struct sandbox_state *state,
state->write_ram_buf = true;
state->ram_buf_fname = arg;
- if (os_read_ram_buf(arg)) {
+ err = os_read_ram_buf(arg);
+ if (err) {
printf("Failed to read RAM buffer\n");
return err;
}