summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Sealey <matt@genesi-usa.com>2012-08-17 08:15:10 +0000
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>2012-09-01 14:58:27 +0200
commit784097ae5a88f3f0b9aeab589e22091c3bf0f846 (patch)
tree9d4c3a9058c657350c31373855db282d20a66091
parent0aff384b1480c4adf0ba4d3676b213b0ef57ba76 (diff)
downloadu-boot-imx-784097ae5a88f3f0b9aeab589e22091c3bf0f846.zip
u-boot-imx-784097ae5a88f3f0b9aeab589e22091c3bf0f846.tar.gz
u-boot-imx-784097ae5a88f3f0b9aeab589e22091c3bf0f846.tar.bz2
spi: fix mxc_spi_slave structure allocation to clear memory
Use calloc() instead of malloc() to allocate the mxc_spi_slave structure. Clearing the memory is necessary since most of the time this gets done super early in boot, but on warm reboots, and when SPI probing is done long after the init stages it could actually pick up previously used memory, and things like the chipselect polarity and other data end up being filled with trash data if not explicitly set by the board files. This solves a semi-random, almost unreproducable error whereby SPI devices act very, very strangly on boot. Tested on Efika MX over several years.. Signed-off-by: Matt Sealey <matt@genesi-usa.com> Acked-by: Stefano Babic <sbabic@denx.de>
-rw-r--r--drivers/spi/mxc_spi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/mxc_spi.c b/drivers/spi/mxc_spi.c
index cf1462f..13bebe8 100644
--- a/drivers/spi/mxc_spi.c
+++ b/drivers/spi/mxc_spi.c
@@ -408,7 +408,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
if (bus >= ARRAY_SIZE(spi_bases))
return NULL;
- mxcs = malloc(sizeof(struct mxc_spi_slave));
+ mxcs = calloc(sizeof(struct mxc_spi_slave), 1);
if (!mxcs) {
puts("mxc_spi: SPI Slave not allocated !\n");
return NULL;