diff options
| author | Jon Loeliger <jdl@freescale.com> | 2008-09-25 11:02:17 -0500 |
|---|---|---|
| committer | Gerald Van Baren <vanbaren@cideas.com> | 2008-10-01 22:01:52 -0400 |
| commit | 741a6d010d09b5bafca8e4cdfb6b2f8a2c07994d (patch) | |
| tree | e980613007375a209df7a888a0acbc0a6459fea1 | |
| parent | bbdbc7cb3abefda5bd998edbcf0508fe6256327d (diff) | |
| download | u-boot-imx-741a6d010d09b5bafca8e4cdfb6b2f8a2c07994d.zip u-boot-imx-741a6d010d09b5bafca8e4cdfb6b2f8a2c07994d.tar.gz u-boot-imx-741a6d010d09b5bafca8e4cdfb6b2f8a2c07994d.tar.bz2 | |
Fix an overflow case in fdt_offset_ptr() detected by GCC 4.3.
Using Gcc 4.3 detected this problem:
../dtc/libfdt/fdt.c: In function 'fdt_next_tag':
../dtc/libfdt/fdt.c:82: error: assuming signed overflow does not
occur when assuming that (X + c) < X is always false
To fix the problem, treat the offset as an unsigned int.
The problem report and proposed fix were provided
by Steve Papacharalambous <stevep@freescale.com>.
Signed-off-by: Jon Loeliger <jdl@freescale.com>
| -rw-r--r-- | include/libfdt.h | 2 | ||||
| -rw-r--r-- | libfdt/fdt.c | 2 |
2 files changed, 2 insertions, 2 deletions
diff --git a/include/libfdt.h b/include/libfdt.h index 94c35e3..5492a53 100644 --- a/include/libfdt.h +++ b/include/libfdt.h @@ -122,7 +122,7 @@ /* Low-level functions (you probably don't need these) */ /**********************************************************************/ -const void *fdt_offset_ptr(const void *fdt, int offset, int checklen); +const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int checklen); static inline void *fdt_offset_ptr_w(void *fdt, int offset, int checklen) { return (void *)(uintptr_t)fdt_offset_ptr(fdt, offset, checklen); diff --git a/libfdt/fdt.c b/libfdt/fdt.c index 732103b..a59a518 100644 --- a/libfdt/fdt.c +++ b/libfdt/fdt.c @@ -78,7 +78,7 @@ int fdt_check_header(const void *fdt) return 0; } -const void *fdt_offset_ptr(const void *fdt, int offset, int len) +const void *fdt_offset_ptr(const void *fdt, int offset, unsigned int len) { const char *p; |