diff options
| author | Stephen Warren <swarren@wwwdotorg.org> | 2016-04-13 22:29:52 -0600 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2016-04-18 17:11:47 -0400 |
| commit | e3a46e3ee22876606254560ec4c10903074475c2 (patch) | |
| tree | 66f6d3a2d1d5552a0d63d4fe50cd91412db9c83d | |
| parent | 28983f4b1a62f94e1d0ba01958f42364abccc925 (diff) | |
| download | u-boot-imx-e3a46e3ee22876606254560ec4c10903074475c2.zip u-boot-imx-e3a46e3ee22876606254560ec4c10903074475c2.tar.gz u-boot-imx-e3a46e3ee22876606254560ec4c10903074475c2.tar.bz2 | |
serial: bcm283x_mu: make pending values more explicit
dm_serial_ops.pending should return the number of characters, not just a
valid C Boolean integer value. The existing code does already does this,
but only as an accident since BCM283X_MU_LSR_RX_READY happens to be
BIT(0). Enhance the code to be more explicit about the values it returns.
Suggested-by: Simon Glass <sjg@chromium.org>
Signed-off-by: Stephen Warren <swarren@wwwdotorg.org>
| -rw-r--r-- | drivers/serial/serial_bcm283x_mu.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/drivers/serial/serial_bcm283x_mu.c b/drivers/serial/serial_bcm283x_mu.c index fc36bc0..7357bbf 100644 --- a/drivers/serial/serial_bcm283x_mu.c +++ b/drivers/serial/serial_bcm283x_mu.c @@ -116,9 +116,9 @@ static int bcm283x_mu_serial_pending(struct udevice *dev, bool input) if (input) { WATCHDOG_RESET(); - return lsr & BCM283X_MU_LSR_RX_READY; + return (lsr & BCM283X_MU_LSR_RX_READY) ? 1 : 0; } else { - return !(lsr & BCM283X_MU_LSR_TX_IDLE); + return (lsr & BCM283X_MU_LSR_TX_IDLE) ? 0 : 1; } } |