diff options
| author | Tom Rini <trini@konsulko.com> | 2016-04-12 15:11:24 -0400 |
|---|---|---|
| committer | Tom Rini <trini@konsulko.com> | 2016-04-18 17:11:42 -0400 |
| commit | 3bfc8152b2c09d81fb00f4d3990e5dfd59682b96 (patch) | |
| tree | 056052f8c6b5858614b1ffef4d6798745668a40b | |
| parent | aa997d1d774416b3525d44779ee7ff9914b6abcb (diff) | |
| download | u-boot-imx-3bfc8152b2c09d81fb00f4d3990e5dfd59682b96.zip u-boot-imx-3bfc8152b2c09d81fb00f4d3990e5dfd59682b96.tar.gz u-boot-imx-3bfc8152b2c09d81fb00f4d3990e5dfd59682b96.tar.bz2 | |
drivers/power/pmic/pm8916.c: Make usid be uint32_t
If get_dev_addr fails it will return FDT_ADDR_T_NONE and:
>>> "priv->usid == 4294967295U" is always false regardless of the values of its operands. This occurs as the logical operand of if.
Cc: Mateusz Kulikowski <mateusz.kulikowski@gmail.com>
Reported-by: Coverity (CID: 143914)
Signed-off-by: Tom Rini <trini@konsulko.com>
| -rw-r--r-- | drivers/power/pmic/pm8916.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/power/pmic/pm8916.c b/drivers/power/pmic/pm8916.c index 9acf5f5..d4c7d4a 100644 --- a/drivers/power/pmic/pm8916.c +++ b/drivers/power/pmic/pm8916.c @@ -18,7 +18,7 @@ DECLARE_GLOBAL_DATA_PTR; #define REG_MASK 0xFF struct pm8916_priv { - uint16_t usid; /* Slave ID on SPMI bus */ + uint32_t usid; /* Slave ID on SPMI bus */ }; static int pm8916_reg_count(struct udevice *dev) |