Browse Source

[ALSA] NULL pointer dereference in sound/synth/emux/soundfont.c

this is about coverity id #100.
It seems the if statement is negated, since the else branch calls
remove_info() with sflist->currsf as a parameter where it gets
dereferenced.

Signed-off-by: Eric Sesterhenn <snakebyte@gmx.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
imx_3.10.17_1.0.0_ga
Eric Sesterhenn 15 years ago
committed by Jaroslav Kysela
parent
commit
d20cad602f
1 changed files with 1 additions and 1 deletions
  1. +1
    -1
      sound/synth/emux/soundfont.c

+ 1
- 1
sound/synth/emux/soundfont.c View File

@ -195,7 +195,7 @@ snd_soundfont_load(struct snd_sf_list *sflist, const void __user *data,
break;
case SNDRV_SFNT_REMOVE_INFO:
/* patch must be opened */
if (sflist->currsf) {
if (!sflist->currsf) {
snd_printk("soundfont: remove_info: patch not opened\n");
rc = -EINVAL;
} else {


Loading…
Cancel
Save