Browse Source

ALSA: core: fix buffer overflow in snd_info_get_line()

commit ddc64b278a upstream.

snd_info_get_line() documents that its last parameter must be one
less than the buffer size, but this API design guarantees that
(literally) every caller gets it wrong.

Just change this parameter to have its obvious meaning.

Reported-by: Tommi Rantala <tt.rantala@gmail.com>
Signed-off-by: Clemens Ladisch <clemens@ladisch.de>
Signed-off-by: Takashi Iwai <tiwai@suse.de>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
isee-imx_3.14.28.y
Clemens Ladisch 6 years ago
committed by Greg Kroah-Hartman
parent
commit
80669110f1
1 changed files with 2 additions and 2 deletions
  1. +2
    -2
      sound/core/info.c

+ 2
- 2
sound/core/info.c View File

@ -679,7 +679,7 @@ int snd_info_card_free(struct snd_card *card)
* snd_info_get_line - read one line from the procfs buffer
* @buffer: the procfs buffer
* @line: the buffer to store
* @len: the max. buffer size - 1
* @len: the max. buffer size
*
* Reads one line from the buffer and stores the string.
*
@ -699,7 +699,7 @@ int snd_info_get_line(struct snd_info_buffer *buffer, char *line, int len)
buffer->stop = 1;
if (c == '\n')
break;
if (len) {
if (len > 1) {
len--;
*line++ = c;
}


Loading…
Cancel
Save