From d02be99e6774b99c27b7d4304865c7f45e1ac4b4 Mon Sep 17 00:00:00 2001 From: Bin Meng Date: Mon, 1 Feb 2016 01:40:41 -0800 Subject: dm: pch: Remove pch_get_version op pch_get_version op was only used by the ich spi controller driver, and does not really provide a good identification of pch controller so far, since we see plenty of Intel PCH chipsets and one differs from another a lot, which is not simply either a PCHV_7 or PCHV_9. Now that ich spi controller driver was updated to not get such info from pch, the pch_get_version op is useless now. Signed-off-by: Bin Meng Reviewed-by: Simon Glass Tested-by: Simon Glass --- drivers/pch/pch-uclass.c | 10 ---------- drivers/pch/pch7.c | 6 ------ drivers/pch/pch9.c | 6 ------ 3 files changed, 22 deletions(-) (limited to 'drivers') diff --git a/drivers/pch/pch-uclass.c b/drivers/pch/pch-uclass.c index 4579ed1..cae4f50 100644 --- a/drivers/pch/pch-uclass.c +++ b/drivers/pch/pch-uclass.c @@ -23,16 +23,6 @@ int pch_get_sbase(struct udevice *dev, ulong *sbasep) return ops->get_sbase(dev, sbasep); } -enum pch_version pch_get_version(struct udevice *dev) -{ - struct pch_ops *ops = pch_get_ops(dev); - - if (!ops->get_version) - return -ENOSYS; - - return ops->get_version(dev); -} - int pch_set_spi_protect(struct udevice *dev, bool protect) { struct pch_ops *ops = pch_get_ops(dev); diff --git a/drivers/pch/pch7.c b/drivers/pch/pch7.c index ef72422..7c6a2ca 100644 --- a/drivers/pch/pch7.c +++ b/drivers/pch/pch7.c @@ -22,11 +22,6 @@ static int pch7_get_sbase(struct udevice *dev, ulong *sbasep) return 0; } -static enum pch_version pch7_get_version(struct udevice *dev) -{ - return PCHV_7; -} - static int pch7_set_spi_protect(struct udevice *dev, bool protect) { uint8_t bios_cntl; @@ -44,7 +39,6 @@ static int pch7_set_spi_protect(struct udevice *dev, bool protect) static const struct pch_ops pch7_ops = { .get_sbase = pch7_get_sbase, - .get_version = pch7_get_version, .set_spi_protect = pch7_set_spi_protect, }; diff --git a/drivers/pch/pch9.c b/drivers/pch/pch9.c index 529cb02..27a9fda 100644 --- a/drivers/pch/pch9.c +++ b/drivers/pch/pch9.c @@ -20,14 +20,8 @@ static int pch9_get_sbase(struct udevice *dev, ulong *sbasep) return 0; } -static enum pch_version pch9_get_version(struct udevice *dev) -{ - return PCHV_9; -} - static const struct pch_ops pch9_ops = { .get_sbase = pch9_get_sbase, - .get_version = pch9_get_version, }; static const struct udevice_id pch9_ids[] = { -- cgit v1.1