From f20562e4c40adc3a16cfce4d7715e77969eccd0a Mon Sep 17 00:00:00 2001 From: Peng Fan Date: Mon, 7 Sep 2015 14:59:48 +0800 Subject: mx6: remove SYS_SOC from board Kconfig MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Remove duplicated SYS_SOC Kconfig entry from board Kconfig, because we have this entry in arch/arm/cpu/armv7/mx6/Kconfig. Signed-off-by: Peng Fan Cc: Stefano Babic Cc: Heiko Schocher Cc: Christian Gmeiner Cc: Stefan Roese Cc: Troy Kisky Cc: Nikita Kiryanov Cc: "Eric BĂ©nard" Cc: Fabio Estevam Cc: Tim Harvey Cc: Marek Vasut Cc: Markus Niebel Cc: Otavio Salvador Acked-by: Stefan Roese Acked-by: Marek Vasut Acked-by: Christian Gmeiner Acked-by: Markus Niebel Acked-by: Troy Kisky Acked-by: Igor Grinberg --- board/boundary/nitrogen6x/Kconfig | 3 --- 1 file changed, 3 deletions(-) (limited to 'board/boundary') diff --git a/board/boundary/nitrogen6x/Kconfig b/board/boundary/nitrogen6x/Kconfig index 03b0f6f..f4db56d 100644 --- a/board/boundary/nitrogen6x/Kconfig +++ b/board/boundary/nitrogen6x/Kconfig @@ -6,9 +6,6 @@ config SYS_BOARD config SYS_VENDOR default "boundary" -config SYS_SOC - default "mx6" - config SYS_CONFIG_NAME default "nitrogen6x" -- cgit v1.1 From 747472bb960e37080e0f498f7cf752a89ad148c9 Mon Sep 17 00:00:00 2001 From: Fabio Estevam Date: Fri, 11 Sep 2015 00:53:51 -0300 Subject: nitrogen6x: Fix the error handling in board_eth_init() We should not return 0 on failure, so return a negative error code instead. Also centralize the error path so that is easier to follow. Cc: Troy Kisky Signed-off-by: Fabio Estevam Acked-by: Troy Kisky --- board/boundary/nitrogen6x/nitrogen6x.c | 19 +++++++++++-------- 1 file changed, 11 insertions(+), 8 deletions(-) (limited to 'board/boundary') diff --git a/board/boundary/nitrogen6x/nitrogen6x.c b/board/boundary/nitrogen6x/nitrogen6x.c index d46b8db..104d71f 100644 --- a/board/boundary/nitrogen6x/nitrogen6x.c +++ b/board/boundary/nitrogen6x/nitrogen6x.c @@ -387,20 +387,17 @@ int board_eth_init(bd_t *bis) #ifdef CONFIG_FEC_MXC bus = fec_get_miibus(base, -1); if (!bus) - return 0; + return -EINVAL; /* scan phy 4,5,6,7 */ phydev = phy_find_by_mask(bus, (0xf << 4), PHY_INTERFACE_MODE_RGMII); if (!phydev) { - free(bus); - return 0; + ret = -EINVAL; + goto free_bus; } printf("using phy at %d\n", phydev->addr); ret = fec_probe(bis, -1, base, bus, phydev); - if (ret) { - printf("FEC MXC: %s:failed\n", __func__); - free(phydev); - free(bus); - } + if (ret) + goto free_phydev; #endif #ifdef CONFIG_CI_UDC @@ -408,6 +405,12 @@ int board_eth_init(bd_t *bis) usb_eth_initialize(bis); #endif return 0; + +free_phydev: + free(phydev); +free_bus: + free(bus); + return ret; } static void setup_buttons(void) -- cgit v1.1