From f0c0b3a9e6f28a34d6da5edabba1e874fdf8e675 Mon Sep 17 00:00:00 2001 From: Wolfgang Denk Date: Wed, 4 May 2011 10:32:28 +0000 Subject: Fix incorrect use of getenv() before relocation A large number of boards incorrectly used getenv() in their board init code running before relocation. In some cases this caused U-Boot to hang when certain environment variables grew too long. Fix the code to use getenv_r(). Signed-off-by: Wolfgang Denk Cc: Stefan Roese Cc: The LEOX team Cc: Michael Schwingen Cc: Georg Schardt Cc: Werner Pfister Cc: Dirk Eibach Cc: Peter De Schrijver Cc: John Zhan Cc: Rishi Bhattacharya Cc: Peter Tyser --- board/actux1/actux1.c | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) (limited to 'board/actux1') diff --git a/board/actux1/actux1.c b/board/actux1/actux1.c index e73aff8..85e3f9e 100644 --- a/board/actux1/actux1.c +++ b/board/actux1/actux1.c @@ -89,14 +89,15 @@ int board_init (void) */ int checkboard (void) { - char *s = getenv ("serial#"); + char buf[64]; + int i = getenv_f("serial#", buf, sizeof(buf)); puts ("Board: AcTux-1 rev."); putc (ACTUX1_BOARDREL + 'A' - 1); - if (s != NULL) { - puts (", serial# "); - puts (s); + if (i > 0) { + puts(", serial# "); + puts(buf); } putc ('\n'); -- cgit v1.1