diff options
author | Peter Tyser <ptyser@xes-inc.com> | 2015-01-26 11:42:21 -0600 |
---|---|---|
committer | Simon Glass <sjg@chromium.org> | 2015-01-30 15:52:29 -0700 |
commit | 2181830f11c2bbfea31e5f3f957577a619fc3776 (patch) | |
tree | 08a88736bafaeb9b54d7c76a6d2cabc7cae9fd40 /tools/patman/gitutil.py | |
parent | 1f32ae95784acee8a2233043aa18bf1b3a4974d7 (diff) | |
download | u-boot-imx-2181830f11c2bbfea31e5f3f957577a619fc3776.zip u-boot-imx-2181830f11c2bbfea31e5f3f957577a619fc3776.tar.gz u-boot-imx-2181830f11c2bbfea31e5f3f957577a619fc3776.tar.bz2 |
patman: Make dry-run output match real functionality
When run with the --dry-run argument patman prints out information
showing what it would do. This information currently doesn't line up
with what patman/git send-email really do. Some basic examples:
- If an email address is addressed via "Series-cc" and "Patch-cc" patman
shows that email address would be CC-ed two times.
- If an email address is addressed via "Series-to" and "Patch-cc" patman
shows that email address would be sent TO and CC-ed.
- If an email address is addressed from a combination of tag aliases,
get_maintainer.pl output, "Series-cc", "Patch-cc", etc patman shows
that the email address would be CC-ed multiple times.
Patman currently does try to send duplicate emails like the --dry-run
output shows, but "git send-email" intelligently removes duplicate
addresses so this patch shouldn't change the non-dry-run functionality.
Change patman's output and email addressing to line up with the
"git send-email" logic. This trims down patman's dry-run output and
prevents confusion about what patman will do when emails are actually
sent.
Signed-off-by: Peter Tyser <ptyser@xes-inc.com>
Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'tools/patman/gitutil.py')
-rw-r--r-- | tools/patman/gitutil.py | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/tools/patman/gitutil.py b/tools/patman/gitutil.py index cc5a55a..c593070 100644 --- a/tools/patman/gitutil.py +++ b/tools/patman/gitutil.py @@ -392,7 +392,8 @@ def EmailPatches(series, cover_fname, args, dry_run, raise_on_error, cc_fname, "Or do something like this\n" "git config sendemail.to u-boot@lists.denx.de") return - cc = BuildEmailList(series.get('cc'), '--cc', alias, raise_on_error) + cc = BuildEmailList(list(set(series.get('cc')) - set(series.get('to'))), + '--cc', alias, raise_on_error) if self_only: to = BuildEmailList([os.getenv('USER')], '--to', alias, raise_on_error) cc = [] |