summaryrefslogtreecommitdiff
path: root/tools/env
diff options
context:
space:
mode:
authorMike Frysinger <vapier@gentoo.org>2012-11-10 19:47:46 +0000
committerTom Rini <trini@ti.com>2012-12-19 15:51:57 -0700
commit7a546db2ffc6a713fb8009d8246c29da5420f6a7 (patch)
tree47935bb66275194884d3db755a50b3f8f7666f54 /tools/env
parent3779c8e319bd5e3fb32c3036cc0d3a658f920fa3 (diff)
downloadu-boot-imx-7a546db2ffc6a713fb8009d8246c29da5420f6a7.zip
u-boot-imx-7a546db2ffc6a713fb8009d8246c29da5420f6a7.tar.gz
u-boot-imx-7a546db2ffc6a713fb8009d8246c29da5420f6a7.tar.bz2
fw_env: fix incorrect usage of open(O_CREAT)
When using open(), the O_CREAT flag must be given a mode, otherwise it uses random garbage from the stack. Also, it can fail to build: In file included from /usr/include/fcntl.h:290:0, from fw_env_main.c:42: In function 'open', inlined from 'main' at fw_env_main.c:97:9: /usr/include/bits/fcntl2.h:50:24: error: call to '__open_missing_mode' declared with attribute error: open with O_CREAT in second argument needs 3 arguments Signed-off-by: Mike Frysinger <vapier@gentoo.org> Acked-by: Joe Hershberger <joe.hershberger@ni.com>
Diffstat (limited to 'tools/env')
-rw-r--r--tools/env/fw_env_main.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/tools/env/fw_env_main.c b/tools/env/fw_env_main.c
index c855f4c..40ea3f6 100644
--- a/tools/env/fw_env_main.c
+++ b/tools/env/fw_env_main.c
@@ -94,7 +94,7 @@ int main(int argc, char *argv[])
int lockfd = -1;
int retval = EXIT_SUCCESS;
- lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC);
+ lockfd = open(lockname, O_WRONLY | O_CREAT | O_TRUNC, 0666);
if (-1 == lockfd) {
fprintf(stderr, "Error opening lock file %s\n", lockname);
return EXIT_FAILURE;