summaryrefslogtreecommitdiff
path: root/include/stdio_dev.h
diff options
context:
space:
mode:
authorAxel Lin <axel.lin@ingics.com>2015-01-06 08:08:25 +0800
committerJagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>2015-01-06 15:52:27 +0530
commit501943696ea4f4194705b7449547fd3d66c13e97 (patch)
tree2bca892c4f617a13727cfec6d6389a7e2b9e83ec /include/stdio_dev.h
parentd622ac39274a949b6445f1bfd92dc1644014388b (diff)
downloadu-boot-imx-501943696ea4f4194705b7449547fd3d66c13e97.zip
u-boot-imx-501943696ea4f4194705b7449547fd3d66c13e97.tar.gz
u-boot-imx-501943696ea4f4194705b7449547fd3d66c13e97.tar.bz2
spi: designware_spi: Fix detecting FIFO depth
Current code tries to find the highest valid fifo depth by checking the value it wrote to DW_SPI_TXFLTR. There are a few problems in current code: 1) There is an off-by-one in dws->fifo_len setting because it assumes the latest register write fails so the latest valid value should be fifo - 1. 2) We know the depth could be from 2 to 256 from HW spec, so it is not necessary to test fifo == 257. In the case fifo is 257, it means the latest valid setting is fifo = 256. So after the for loop iteration, we should check fifo == 2 case instead of fifo == 257 if detecting the FIFO depth fails. This patch fixes above issues. Signed-off-by: Axel Lin <axel.lin@ingics.com> Acked-by: Stefan Roese <sr@denx.de> Reviewed-by: Jagannadha Sutradharudu Teki <jagannadh.teki@gmail.com>
Diffstat (limited to 'include/stdio_dev.h')
0 files changed, 0 insertions, 0 deletions