diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2014-06-09 11:36:55 +0200 |
|---|---|---|
| committer | Ian Campbell <ijc@hellion.org.uk> | 2014-07-06 20:12:44 +0100 |
| commit | b6ae6765c5a9e5daa3799e4d65562d3184712506 (patch) | |
| tree | 8d8a7dd77cd7c42c89d514671ce850212f980dd3 /include/configs | |
| parent | 9e5f80d823e3fd2a685b10ecf02009e34b86cff9 (diff) | |
| download | u-boot-imx-b6ae6765c5a9e5daa3799e4d65562d3184712506.zip u-boot-imx-b6ae6765c5a9e5daa3799e4d65562d3184712506.tar.gz u-boot-imx-b6ae6765c5a9e5daa3799e4d65562d3184712506.tar.bz2 | |
sunxi: Remove mmc DMA support
The DMA code in sunxi_mmc.c is broken. mmc_trans_data_by_dma() allocates the
dma descriptors on the stack, and then exits while the dma transfer is in
progress, so the dma engine is reading stack memory which at that point may
be re-used. So far we've gotten away with this by luck, but recent u-boot
changes have shifted the stack start address by 16 bytes, which combined
with dma alignment now exposes this problem.
Since we end up just busy waiting for the dma engine anyway, this commit
fixes things by simply removing the dma code, resulting in smaller bug-free
code.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Acked-by: Ian Campbell <ijc@hellion.org.uk>
Diffstat (limited to 'include/configs')
| -rw-r--r-- | include/configs/sunxi-common.h | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/include/configs/sunxi-common.h b/include/configs/sunxi-common.h index 5d72d62..fd02d0d 100644 --- a/include/configs/sunxi-common.h +++ b/include/configs/sunxi-common.h @@ -70,7 +70,6 @@ #define CONFIG_CMD_MMC #define CONFIG_MMC_SUNXI #define CONFIG_MMC_SUNXI_SLOT 0 -#define CONFIG_MMC_SUNXI_USE_DMA #define CONFIG_ENV_IS_IN_MMC #define CONFIG_SYS_MMC_ENV_DEV 0 /* first detected MMC controller */ |