diff options
author | Stephen Warren <swarren@nvidia.com> | 2014-04-24 17:52:38 -0600 |
---|---|---|
committer | Marek Vasut <marex@denx.de> | 2014-04-30 10:30:57 +0200 |
commit | 0c51dc6db9ea0e3912d1d3e2d953bc22de433c60 (patch) | |
tree | a8c8d5a8fc75d4ef85ece18e09ed427e126d1567 /drivers/tpm | |
parent | 8aac6e9c537a2dd0c76acc3a0768ae7af5e166ab (diff) | |
download | u-boot-imx-0c51dc6db9ea0e3912d1d3e2d953bc22de433c60.zip u-boot-imx-0c51dc6db9ea0e3912d1d3e2d953bc22de433c60.tar.gz u-boot-imx-0c51dc6db9ea0e3912d1d3e2d953bc22de433c60.tar.bz2 |
usb: ci_udc: make PHY initialization conditional
usb_gadget_register_driver() currently unconditionally programs PORTSC
to select a ULPI PHY. This is incorrect on at least the Tegra boards I
am testing with, which use a UTMI PHY for the OTG ports. Make the PHY
selection code conditional upon the specific EHCI controller that is in
use.
Ideally, I believe that the PHY initialization code should be part of
ehci_hcd_init() in the relevant EHCI controller driver, or some board-
specific function that ehci_hcd_init() calls.
For MX6, I'm not sure this PHY initialization code is correct even before
this patch, since ehci-mx6's ehci_hcd_init() already configures PORTSC to
a board-specific value, and it seems likely that the code in ci_udc.c is
incorrectly undoing this. Perhaps this is not an issue if the PHY
selection register bits aren't implemented on this instance of the MX6
USB controller?
ehci-mxs.c doens't appear to touch PORTSC, so this code is likely still
required there.
Signed-off-by: Stephen Warren <swarren@nvidia.com>
Diffstat (limited to 'drivers/tpm')
0 files changed, 0 insertions, 0 deletions