summaryrefslogtreecommitdiff
path: root/drivers/hwmon/lm63.c
diff options
context:
space:
mode:
authorHeiko Schocher <hs@denx.de>2011-08-01 04:01:43 +0000
committerWolfgang Denk <wd@denx.de>2011-08-04 23:30:38 +0200
commit780f13a9e1a21098c6255aaa1c46ed80aa7a436c (patch)
tree4273c1af78aa2f3079e11997e12814d66d47439e /drivers/hwmon/lm63.c
parentfb6440ee9b110b759ef61fd80bbd0df1bbf0f37b (diff)
downloadu-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.zip
u-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.tar.gz
u-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.tar.bz2
hwmon: do not init sensors on startup
The U-Boot Design Principles[1] clearly say: Initialize devices only when they are needed within U-Boot, i.e. don't initialize the Ethernet interface(s) unless U-Boot performs a download over Ethernet; don't initialize any IDE or USB devices unless U-Boot actually tries to load files from these, etc. (and don't forget to shut down these devices after using them - otherwise nasty things may happen when you try to boot your OS). So, do not initialize and read the sensors on startup. Signed-off-by: Heiko Schocher <hs@denx.de> cc: Wolfgang Denk <wd@denx.de> cc: Holger Brunck <holger.brunck@keymile.com>
Diffstat (limited to 'drivers/hwmon/lm63.c')
-rw-r--r--drivers/hwmon/lm63.c19
1 files changed, 1 insertions, 18 deletions
diff --git a/drivers/hwmon/lm63.c b/drivers/hwmon/lm63.c
index 2f1f3cf..f3adf64 100644
--- a/drivers/hwmon/lm63.c
+++ b/drivers/hwmon/lm63.c
@@ -101,7 +101,7 @@ static int is_lm64(int sensor)
return sensor && (sensor != DTT_I2C_LM63_ADDR);
}
-static int _dtt_init(int sensor)
+int dtt_init_one(int sensor)
{
int i;
int val;
@@ -175,20 +175,3 @@ int dtt_get_temp(int sensor)
/* Ignore LSB for now, U-Boot only prints natural numbers */
return temp >> 8;
}
-
-int dtt_init(void)
-{
- int i;
- unsigned char sensors[] = CONFIG_DTT_SENSORS;
- const char *const header = "DTT: ";
-
- for (i = 0; i < sizeof(sensors); i++) {
- if (_dtt_init(sensors[i]) != 0)
- printf("%s%d FAILED INIT\n", header, i + 1);
- else
- printf("%s%d is %i C\n", header, i + 1,
- dtt_get_temp(sensors[i]));
- }
-
- return 0;
-}