diff options
author | Heiko Schocher <hs@denx.de> | 2011-08-01 04:01:43 +0000 |
---|---|---|
committer | Wolfgang Denk <wd@denx.de> | 2011-08-04 23:30:38 +0200 |
commit | 780f13a9e1a21098c6255aaa1c46ed80aa7a436c (patch) | |
tree | 4273c1af78aa2f3079e11997e12814d66d47439e /drivers/hwmon/adm1021.c | |
parent | fb6440ee9b110b759ef61fd80bbd0df1bbf0f37b (diff) | |
download | u-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.zip u-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.tar.gz u-boot-imx-780f13a9e1a21098c6255aaa1c46ed80aa7a436c.tar.bz2 |
hwmon: do not init sensors on startup
The U-Boot Design Principles[1] clearly say:
Initialize devices only when they are needed within U-Boot, i.e. don't
initialize the Ethernet interface(s) unless U-Boot performs a download
over Ethernet; don't initialize any IDE or USB devices unless U-Boot
actually tries to load files from these, etc. (and don't forget to
shut down these devices after using them - otherwise nasty things may
happen when you try to boot your OS).
So, do not initialize and read the sensors on startup.
Signed-off-by: Heiko Schocher <hs@denx.de>
cc: Wolfgang Denk <wd@denx.de>
cc: Holger Brunck <holger.brunck@keymile.com>
Diffstat (limited to 'drivers/hwmon/adm1021.c')
-rw-r--r-- | drivers/hwmon/adm1021.c | 27 |
1 files changed, 3 insertions, 24 deletions
diff --git a/drivers/hwmon/adm1021.c b/drivers/hwmon/adm1021.c index d753e9a..d074cb7 100644 --- a/drivers/hwmon/adm1021.c +++ b/drivers/hwmon/adm1021.c @@ -109,8 +109,8 @@ dtt_write (int sensor, int reg, int val) return 0; } /* dtt_write() */ -static int -_dtt_init (int sensor) +int +dtt_init_one(int sensor) { dtt_cfg_t *dcp = &dttcfg[sensor >> 1]; int reg, val; @@ -164,28 +164,7 @@ _dtt_init (int sensor) return 1; return 0; -} /* _dtt_init() */ - -int -dtt_init (void) -{ - int i; - unsigned char sensors[] = CONFIG_DTT_SENSORS; - const char *const header = "DTT: "; - - /* switch to correct I2C bus */ - I2C_SET_BUS(CONFIG_SYS_DTT_BUS_NUM); - - for (i = 0; i < sizeof(sensors); i++) { - if (_dtt_init(sensors[i]) != 0) - printf ("%s%d FAILED INIT\n", header, i+1); - else - printf ("%s%d is %i C\n", header, i+1, - dtt_get_temp(sensors[i])); - } - - return (0); -} /* dtt_init() */ +} /* dtt_init_one() */ int dtt_get_temp (int sensor) |