diff options
author | Wolfgang Denk <wd@denx.de> | 2013-10-05 21:07:25 +0200 |
---|---|---|
committer | Tom Rini <trini@ti.com> | 2013-10-07 15:54:18 -0400 |
commit | b770e88a6c2548727f0d57a3e9e8bb0830f977b5 (patch) | |
tree | 469c25b2cd059fe019fe87e334b8f4bf0f2134ea /common/cmd_fs.c | |
parent | 010c480bbf9c3c2b4237a73242b4b3f7c9198114 (diff) | |
download | u-boot-imx-b770e88a6c2548727f0d57a3e9e8bb0830f977b5.zip u-boot-imx-b770e88a6c2548727f0d57a3e9e8bb0830f977b5.tar.gz u-boot-imx-b770e88a6c2548727f0d57a3e9e8bb0830f977b5.tar.bz2 |
Fix number base handling of "load" command
As documented, almost all U-Boot commands expect numbers to be entered
in hexadecimal input format. (Exception: for historical reasons, the
"sleep" command takes its argument in decimal input format.)
This rule was broken for the "load" command; for details please see
especially commits 045fa1e "fs: add filesystem switch libary,
implement ls and fsload commands" and 3f83c87 "fs: fix number base
behaviour change in fatload/ext*load". In the result, the load
command would always require an explicit "0x" prefix for regular
(i. e. base 16 formatted) input.
Change this to use the standard notation of base 16 input format.
While strictly speaking this is a change of the user interface, we
hope that it will not cause trouble. Stephen Warren comments (see
[1]):
I suppose you can change the behaviour if you want; anyone
writing "0x..." for their values presumably won't be
affected, and if people really do assume all values in U-Boot
are in hex, presumably nobody currently relies upon using
non-prefixed values with the generic load command, since it
doesn't work like that right now.
[1] http://article.gmane.org/gmane.comp.boot-loaders.u-boot/171172
Acked-by: Tom Rini <trini@ti.com>
Acked-by: Stephen Warren <swarren@nvidia.com>
Signed-off-by: Wolfgang Denk <wd@denx.de>
Diffstat (limited to 'common/cmd_fs.c')
-rw-r--r-- | common/cmd_fs.c | 6 |
1 files changed, 2 insertions, 4 deletions
diff --git a/common/cmd_fs.c b/common/cmd_fs.c index a681d03..91a205a 100644 --- a/common/cmd_fs.c +++ b/common/cmd_fs.c @@ -22,7 +22,7 @@ int do_load_wrapper(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { - return do_load(cmdtp, flag, argc, argv, FS_TYPE_ANY, 0); + return do_load(cmdtp, flag, argc, argv, FS_TYPE_ANY); } U_BOOT_CMD( @@ -34,9 +34,7 @@ U_BOOT_CMD( " 'bytes' gives the size to load in bytes.\n" " If 'bytes' is 0 or omitted, the file is read until the end.\n" " 'pos' gives the file byte position to start reading from.\n" - " If 'pos' is 0 or omitted, the file is read from the start.\n" - " All numeric parameters are assumed to be decimal,\n" - " unless specified otherwise using a leading \"0x\"." + " If 'pos' is 0 or omitted, the file is read from the start." ); int do_ls_wrapper(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) |