summaryrefslogtreecommitdiff
path: root/board
diff options
context:
space:
mode:
authorFabio Estevam <fabio.estevam@freescale.com>2014-11-20 16:35:19 -0200
committerStefano Babic <sbabic@denx.de>2014-11-21 16:47:55 +0100
commit1abd714de25f47d3b8bfaea9633458aa754e129e (patch)
tree23866a1419797cf52c6f02053a894d6b9a35a027 /board
parentc5ba77ac05eb22b097291eaeb0b956327f1b2b5f (diff)
downloadu-boot-imx-1abd714de25f47d3b8bfaea9633458aa754e129e.zip
u-boot-imx-1abd714de25f47d3b8bfaea9633458aa754e129e.tar.gz
u-boot-imx-1abd714de25f47d3b8bfaea9633458aa754e129e.tar.bz2
mx53evk: Fix error handling in board_mmc_init()
When an invalid USDHC port is passed we should return -EINVAL instead of 0. Also, return the error immediately on fsl_esdhc_initialize() failure. Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Diffstat (limited to 'board')
-rw-r--r--board/freescale/mx53evk/mx53evk.c10
1 files changed, 6 insertions, 4 deletions
diff --git a/board/freescale/mx53evk/mx53evk.c b/board/freescale/mx53evk/mx53evk.c
index 13519e2..6ee6d73 100644
--- a/board/freescale/mx53evk/mx53evk.c
+++ b/board/freescale/mx53evk/mx53evk.c
@@ -195,7 +195,7 @@ int board_mmc_init(bd_t *bis)
};
u32 index;
- s32 status = 0;
+ int ret;
esdhc_cfg[0].sdhc_clk = mxc_get_clock(MXC_ESDHC_CLK);
esdhc_cfg[1].sdhc_clk = mxc_get_clock(MXC_ESDHC3_CLK);
@@ -214,12 +214,14 @@ int board_mmc_init(bd_t *bis)
printf("Warning: you configured more ESDHC controller"
"(%d) as supported by the board(2)\n",
CONFIG_SYS_FSL_ESDHC_NUM);
- return status;
+ return -EINVAL;
}
- status |= fsl_esdhc_initialize(bis, &esdhc_cfg[index]);
+ ret = fsl_esdhc_initialize(bis, &esdhc_cfg[index]);
+ if (ret)
+ return ret;
}
- return status;
+ return 0;
}
#endif