summaryrefslogtreecommitdiff
path: root/arch/x86/lib
diff options
context:
space:
mode:
authorBin Meng <bmeng.cn@gmail.com>2014-12-17 15:50:49 +0800
committerSimon Glass <sjg@chromium.org>2014-12-18 17:26:08 -0700
commit255fd5caa5dda7f1028843753562eff58f3855bc (patch)
treedd181fea0f51800ad68cbbf768e125f143eabb7f /arch/x86/lib
parent5dad97ed61507d96b2f791980f51ee3497a75867 (diff)
downloadu-boot-imx-255fd5caa5dda7f1028843753562eff58f3855bc.zip
u-boot-imx-255fd5caa5dda7f1028843753562eff58f3855bc.tar.gz
u-boot-imx-255fd5caa5dda7f1028843753562eff58f3855bc.tar.bz2
x86: Clean up the FSP support codes
This is the follow-on patch to clean up the FSP support codes: - Remove the _t suffix on the structures defines - Use __packed for structure defines - Use U-Boot's assert() - Use standard bool true/false - Remove read_unaligned64() - Use memcmp() in the compare_guid() - Remove the cast in the memset() call - Replace some magic numbers with macros - Use panic() when no valid FSP image header is found - Change some FSP utility routines to use an fsp_ prefix - Add comment blocks for asm_continuation and fsp_init_done - Remove some casts in find_fsp_header() - Change HOB access macros to static inline routines - Add comments to mention find_fsp_header() may be called in a stackless environment - Add comments to mention init(&params) in fsp_init() cannot be removed Signed-off-by: Bin Meng <bmeng.cn@gmail.com> Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'arch/x86/lib')
-rw-r--r--arch/x86/lib/cmd_hob.c22
1 files changed, 10 insertions, 12 deletions
diff --git a/arch/x86/lib/cmd_hob.c b/arch/x86/lib/cmd_hob.c
index 2fdff2b..b552fe6 100644
--- a/arch/x86/lib/cmd_hob.c
+++ b/arch/x86/lib/cmd_hob.c
@@ -17,18 +17,18 @@ static char *hob_type[] = {
"Memory Allocation",
"Resource Descriptor",
"GUID Extension",
- "Firmware Volumn",
+ "Firmware Volume",
"CPU",
"Memory Pool",
"reserved",
- "Firmware Volumn 2",
+ "Firmware Volume 2",
"Load PEIM Unused",
"UEFI Capsule",
};
int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
{
- union hob_pointers_t hob;
+ union hob_pointers hob;
u16 type;
char *desc;
int i = 0;
@@ -39,29 +39,27 @@ int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
printf("No. | Address | Type | Length in Bytes\n");
printf("----|----------|---------------------|----------------\n");
- while (!END_OF_HOB(hob)) {
+ while (!end_of_hob(hob)) {
printf("%-3d | %08x | ", i, (unsigned int)hob.raw);
- type = hob.hdr->type;
+ type = get_hob_type(hob);
if (type == HOB_TYPE_UNUSED)
desc = "*Unused*";
else if (type == HOB_TYPE_EOH)
- desc = "**END OF HOB**";
+ desc = "*END OF HOB*";
else if (type >= 0 && type <= ARRAY_SIZE(hob_type))
desc = hob_type[type];
else
- desc = "!!!Invalid Type!!!";
- printf("%-19s | %-15d\n", desc, hob.hdr->len);
- hob.raw = GET_NEXT_HOB(hob);
+ desc = "*Invalid Type*";
+ printf("%-19s | %-15d\n", desc, get_hob_length(hob));
+ hob.raw = get_next_hob(hob);
i++;
}
return 0;
}
-/* -------------------------------------------------------------------- */
-
U_BOOT_CMD(
hob, 1, 1, do_hob,
- "print FSP Hand-Off Block information",
+ "print Firmware Support Package (FSP) Hand-Off Block information",
""
);