diff options
| author | Bin Meng <bmeng.cn@gmail.com> | 2014-12-30 16:02:05 +0800 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2015-01-12 17:03:41 -0800 |
| commit | 949dbc12db8ba628004ac70359ca0e0edf98432e (patch) | |
| tree | 1557be2bed61a765a125fab614f74ebdf4afc978 /arch/x86/lib/cmd_hob.c | |
| parent | 8f9052fd98e2e97e33b0e5ccf57f028e595abb5d (diff) | |
| download | u-boot-imx-949dbc12db8ba628004ac70359ca0e0edf98432e.zip u-boot-imx-949dbc12db8ba628004ac70359ca0e0edf98432e.tar.gz u-boot-imx-949dbc12db8ba628004ac70359ca0e0edf98432e.tar.bz2 | |
x86: Simplify the fsp hob access functions
Remove the troublesome union hob_pointers so that some annoying casts
are no longer needed in those hob access routines. This also improves
the readability.
Signed-off-by: Bin Meng <bmeng.cn@gmail.com>
Acked-by: Simon Glass <sjg@chromium.org>
Diffstat (limited to 'arch/x86/lib/cmd_hob.c')
| -rw-r--r-- | arch/x86/lib/cmd_hob.c | 16 |
1 files changed, 8 insertions, 8 deletions
diff --git a/arch/x86/lib/cmd_hob.c b/arch/x86/lib/cmd_hob.c index b552fe6..8d1f038 100644 --- a/arch/x86/lib/cmd_hob.c +++ b/arch/x86/lib/cmd_hob.c @@ -28,20 +28,20 @@ static char *hob_type[] = { int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) { - union hob_pointers hob; + const struct hob_header *hdr; u16 type; char *desc; int i = 0; - hob.raw = (u8 *)gd->arch.hob_list; + hdr = gd->arch.hob_list; - printf("HOB list address: 0x%08x\n\n", (unsigned int)hob.raw); + printf("HOB list address: 0x%08x\n\n", (unsigned int)hdr); printf("No. | Address | Type | Length in Bytes\n"); printf("----|----------|---------------------|----------------\n"); - while (!end_of_hob(hob)) { - printf("%-3d | %08x | ", i, (unsigned int)hob.raw); - type = get_hob_type(hob); + while (!end_of_hob(hdr)) { + printf("%-3d | %08x | ", i, (unsigned int)hdr); + type = get_hob_type(hdr); if (type == HOB_TYPE_UNUSED) desc = "*Unused*"; else if (type == HOB_TYPE_EOH) @@ -50,8 +50,8 @@ int do_hob(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[]) desc = hob_type[type]; else desc = "*Invalid Type*"; - printf("%-19s | %-15d\n", desc, get_hob_length(hob)); - hob.raw = get_next_hob(hob); + printf("%-19s | %-15d\n", desc, get_hob_length(hdr)); + hdr = get_next_hob(hdr); i++; } |