summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSimon Glass <sjg@chromium.org>2016-03-16 07:45:43 -0600
committerTom Rini <trini@konsulko.com>2016-03-22 12:16:28 -0400
commit5b15a2596f7852177c7f451349b353e6e52742a2 (patch)
treead57c454053d645d9e368c0939a1c6022de86a21
parent3bd3a54ac515c26c6f0abd001d74fac2c86a7e1d (diff)
downloadu-boot-imx-5b15a2596f7852177c7f451349b353e6e52742a2.zip
u-boot-imx-5b15a2596f7852177c7f451349b353e6e52742a2.tar.gz
u-boot-imx-5b15a2596f7852177c7f451349b353e6e52742a2.tar.bz2
mkimage: Don't close the file if it wasn't opened
The error path for fit_import_data() is incorrect if the second open() call fails. Reported-by: Coverity (CID: 138489) Signed-off-by: Simon Glass <sjg@chromium.org> Reviewed-by: Tom Rini <trini@konsulko.com>
-rw-r--r--tools/fit_image.c4
1 files changed, 2 insertions, 2 deletions
diff --git a/tools/fit_image.c b/tools/fit_image.c
index 6e5c143..ddefa72 100644
--- a/tools/fit_image.c
+++ b/tools/fit_image.c
@@ -537,8 +537,8 @@ static int fit_import_data(struct image_tool_params *params, const char *fname)
if (fd < 0) {
fprintf(stderr, "%s: Can't open %s: %s\n",
params->cmdname, fname, strerror(errno));
- ret = -EIO;
- goto err;
+ free(fdt);
+ return -EIO;
}
if (write(fd, fdt, new_size) != new_size) {
debug("%s: Failed to write external data to file %s\n",