summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorTom Rini <trini@konsulko.com>2015-11-28 08:04:42 -0500
committerYork Sun <yorksun@freescale.com>2015-12-13 18:27:29 -0800
commitb1f6be5ac8d657e312528ec3c4138c22c54d3f12 (patch)
treead32471fe29274d2c441ec5dd625e7a08acbbf13
parent1a338921642bf622230d91e5eb16b8b5250b44a5 (diff)
downloadu-boot-imx-b1f6be5ac8d657e312528ec3c4138c22c54d3f12.zip
u-boot-imx-b1f6be5ac8d657e312528ec3c4138c22c54d3f12.tar.gz
u-boot-imx-b1f6be5ac8d657e312528ec3c4138c22c54d3f12.tar.bz2
qbman_portal.c: Update BUG_ON() call in qbman_swp_mc_submit
With gcc-5.x we get a warning about the ambiguity of BUG_ON(!a != b) and becomes BUG_ON((!a) != b). In this case reading of the function leads to us wanting to rewrite this as BUG_ON(a != b). Cc: Prabhakar Kushwaha <prabhakar@freescale.com> Cc: Geoff Thorpe <Geoff.Thorpe@freescale.com> Cc: Haiying Wang <Haiying.Wang@freescale.com> Cc: Roy Pledge <Roy.Pledge@freescale.com> Cc: York Sun <yorksun@freescale.com> Signed-off-by: Tom Rini <trini@konsulko.com> Reviewed-by: Bin Meng <bmeng.cn@gmail.com> Reviewed-by: York Sun <yorksun@freescale.com>
-rw-r--r--drivers/net/fsl-mc/dpio/qbman_portal.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/net/fsl-mc/dpio/qbman_portal.c b/drivers/net/fsl-mc/dpio/qbman_portal.c
index 5fa8d95..449ff8a 100644
--- a/drivers/net/fsl-mc/dpio/qbman_portal.c
+++ b/drivers/net/fsl-mc/dpio/qbman_portal.c
@@ -117,7 +117,7 @@ void qbman_swp_mc_submit(struct qbman_swp *p, void *cmd, uint32_t cmd_verb)
{
uint32_t *v = cmd;
#ifdef QBMAN_CHECKING
- BUG_ON(!p->mc.check != swp_mc_can_submit);
+ BUG_ON(p->mc.check != swp_mc_can_submit);
#endif
lwsync();
/* TBD: "|=" is going to hurt performance. Need to move as many fields