diff options
| author | Peng Fan <peng.fan@nxp.com> | 2016-01-10 12:52:15 +0800 |
|---|---|---|
| committer | fang hui <hui.fang@freescale.com> | 2016-03-16 13:48:15 +0800 |
| commit | 38f1899fc2fd2d49d9781a8727a77b677be5fecb (patch) | |
| tree | f6f218964211d04b30c345ed5718ab557f50ade0 | |
| parent | acbb1597a85cff564942a296c04df8c489fa6904 (diff) | |
| download | u-boot-imx-38f1899fc2fd2d49d9781a8727a77b677be5fecb.zip u-boot-imx-38f1899fc2fd2d49d9781a8727a77b677be5fecb.tar.gz u-boot-imx-38f1899fc2fd2d49d9781a8727a77b677be5fecb.tar.bz2 | |
MLK-12200 common: cli_simple: use strlcpy instead of strcpy
Report Coverity log:
Destination buffer too small (STRING_OVERFLOW)
string_overflow: You might overrun the 1024 byte destination string
lastcommand by writing 1025 bytes from console_buffer
Signed-off-by: Peng Fan <peng.fan@nxp.com>
| -rw-r--r-- | common/cli_simple.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/common/cli_simple.c b/common/cli_simple.c index 6c65cc6..690f00b 100644 --- a/common/cli_simple.c +++ b/common/cli_simple.c @@ -275,7 +275,8 @@ void cli_simple_loop(void) flag = 0; /* assume no special flags for now */ if (len > 0) - strcpy(lastcommand, console_buffer); + strlcpy(lastcommand, console_buffer, + CONFIG_SYS_CBSIZE + 1); else if (len == 0) flag |= CMD_FLAG_REPEAT; #ifdef CONFIG_BOOT_RETRY_TIME |