summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorMatt Sealey <matt@genesi-usa.com>2012-08-17 08:15:11 +0000
committerAlbert ARIBAUD <albert.u.boot@aribaud.net>2012-09-01 14:58:27 +0200
commitc6b52c4927df227c94650122363b8b342ddb62f0 (patch)
tree0156b51624d31bca77f166b748051bc03bcf19bd
parent784097ae5a88f3f0b9aeab589e22091c3bf0f846 (diff)
downloadu-boot-imx-c6b52c4927df227c94650122363b8b342ddb62f0.zip
u-boot-imx-c6b52c4927df227c94650122363b8b342ddb62f0.tar.gz
u-boot-imx-c6b52c4927df227c94650122363b8b342ddb62f0.tar.bz2
spi: fix mxs_spi_slave structure allocation to clear memory
Use calloc() instead of malloc() to allocate the mxs_spi_slave structure. Clearing the memory is necessary since most of the time this gets done super early in boot, but on warm reboots, and when SPI probing is done long after the init stages it could actually pick up previously used memory, and things like the chipselect polarity and other data end up being filled with trash data if not explicitly set by the board files. This solves a semi-random, almost unreproducable error whereby SPI devices act very, very strangly on boot. Signed-off-by: Matt Sealey <matt@genesi-usa.com> Acked-by: Stefano Babic <sbabic@denx.de>
-rw-r--r--drivers/spi/mxs_spi.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/drivers/spi/mxs_spi.c b/drivers/spi/mxs_spi.c
index a037c13..5fa7f2b 100644
--- a/drivers/spi/mxs_spi.c
+++ b/drivers/spi/mxs_spi.c
@@ -91,7 +91,7 @@ struct spi_slave *spi_setup_slave(unsigned int bus, unsigned int cs,
return NULL;
}
- mxs_slave = malloc(sizeof(struct mxs_spi_slave));
+ mxs_slave = calloc(sizeof(struct mxs_spi_slave), 1);
if (!mxs_slave)
return NULL;