summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergei Shtylyov <sshtylyov@ru.mvista.com>2007-04-23 15:30:39 +0200
committerStefan Roese <sr@denx.de>2007-04-23 15:30:39 +0200
commit38257988abfe74d459ca2ad748b109ca04e4efe1 (patch)
treeb6c64d109d5333f89132777c5f620947eb109b5b
parentafb903a2eb9436baa9270ccc0c27082d86497d89 (diff)
downloadu-boot-imx-38257988abfe74d459ca2ad748b109ca04e4efe1.zip
u-boot-imx-38257988abfe74d459ca2ad748b109ca04e4efe1.tar.gz
u-boot-imx-38257988abfe74d459ca2ad748b109ca04e4efe1.tar.bz2
[PATCH] Avoid assigning PCI resources from zero address
If a PCI IDE card happens to get a zero address assigned to it, the Linux IDE core complains and IDE drivers fails to work. Also, assigning zero to a BAR was illegal according to PCI 2.1 (the later revisions seem to have excluded the sentence about "0" being considered an invalid address) -- so, use a reasonable starting value of 0x1000 (that's what the most Linux archs are using). Alternatively, one might have fixed the calls to pci_set_region() individually (some code even seems to have taken care of this issue) but that would have been a lot more work. :-) Signed-off-by: Sergei Shtylyov <sshtylyov@ru.mvista.com> Acked-by: Stefan Roese <sr@denx.de>
-rw-r--r--drivers/pci_auto.c7
1 files changed, 6 insertions, 1 deletions
diff --git a/drivers/pci_auto.c b/drivers/pci_auto.c
index 9691675..f170c2d 100644
--- a/drivers/pci_auto.c
+++ b/drivers/pci_auto.c
@@ -34,7 +34,12 @@
void pciauto_region_init(struct pci_region* res)
{
- res->bus_lower = res->bus_start;
+ /*
+ * Avoid allocating PCI resources from address 0 -- this is illegal
+ * according to PCI 2.1 and moreover, this is known to cause Linux IDE
+ * drivers to fail. Use a reasonable starting value of 0x1000 instead.
+ */
+ res->bus_lower = res->bus_start ? res->bus_start : 0x1000;
}
void pciauto_region_align(struct pci_region *res, unsigned long size)