summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRabin Vincent <rabin@rab.in>2014-10-29 23:21:41 +0100
committerTom Rini <trini@ti.com>2014-11-07 16:27:06 -0500
commit2302b3ab85843c9a8dbb3a924030659d87a23349 (patch)
treead20b1650d4c2911831cedcfe59770d372ecf169
parent128059b926b3c34bbb364dcacd8d0511ff906be8 (diff)
downloadu-boot-imx-2302b3ab85843c9a8dbb3a924030659d87a23349.zip
u-boot-imx-2302b3ab85843c9a8dbb3a924030659d87a23349.tar.gz
u-boot-imx-2302b3ab85843c9a8dbb3a924030659d87a23349.tar.bz2
hush: make run_command() return an error on parsing failure
run_command() returns success even if the command had a syntax error; correct this behaviour. Signed-off-by: Rabin Vincent <rabin@rab.in> Acked-by: Simon Glass <sjg@chromium.org)
-rw-r--r--common/cli_hush.c2
-rw-r--r--test/command_ut.c2
2 files changed, 3 insertions, 1 deletions
diff --git a/common/cli_hush.c b/common/cli_hush.c
index a07ae71..d643912 100644
--- a/common/cli_hush.c
+++ b/common/cli_hush.c
@@ -3162,7 +3162,7 @@ static int parse_stream_outer(struct in_str *inp, int flag)
o_string temp=NULL_O_STRING;
int rcode;
#ifdef __U_BOOT__
- int code = 0;
+ int code = 1;
#endif
do {
ctx.type = flag;
diff --git a/test/command_ut.c b/test/command_ut.c
index a4f0341..926573a 100644
--- a/test/command_ut.c
+++ b/test/command_ut.c
@@ -191,6 +191,8 @@ static int do_ut_cmd(cmd_tbl_t *cmdtp, int flag, int argc, char * const argv[])
assert(run_command("", 0) == 0);
assert(run_command(" ", 0) == 0);
+ assert(run_command("'", 0) == 1);
+
printf("%s: Everything went swimmingly\n", __func__);
return 0;
}