diff options
| author | Hans de Goede <hdegoede@redhat.com> | 2014-11-28 14:23:51 +0100 |
|---|---|---|
| committer | Simon Glass <sjg@chromium.org> | 2014-12-01 08:23:32 -0700 |
| commit | ffccb84c1a8e276fa7263ec4ca8186f06312305c (patch) | |
| tree | 31d27d73b71d33abeabf512c8131c02637b05159 | |
| parent | 0bd4e39d2ba477f3c274aa233f5c2e1d25dbaa74 (diff) | |
| download | u-boot-imx-ffccb84c1a8e276fa7263ec4ca8186f06312305c.zip u-boot-imx-ffccb84c1a8e276fa7263ec4ca8186f06312305c.tar.gz u-boot-imx-ffccb84c1a8e276fa7263ec4ca8186f06312305c.tar.bz2 | |
fdt: Fix regression in fdt_pack_reg()
After commit 933cdbb479: "fdt: Try to use fdt_address_cells()/fdt_size_cells()"
I noticed that allwinner boards would no longer boot.
Switching to fdt_address_cells / fdt_size_cells changes the result from
bytes to 32 bit words, so when we increment pointers into the blob, we must
do so by 32 bit words now.
This commit makes allwinner boards boot again.
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Tested-by: Masahiro Yamada <yamada.m@jp.panasonic.com>
Acked-by: Simon Glass <sjg@chromium.org>
Tested-by: Stefan Roese <sr@denx.de>
Tested-by: Vince Hsu <vinceh@nvidia.com>
| -rw-r--r-- | common/fdt_support.c | 12 |
1 files changed, 6 insertions, 6 deletions
diff --git a/common/fdt_support.c b/common/fdt_support.c index ea42c63..6254e34 100644 --- a/common/fdt_support.c +++ b/common/fdt_support.c @@ -370,22 +370,22 @@ static int fdt_pack_reg(const void *fdt, void *buf, u64 *address, u64 *size, int n) { int i; - int address_len = fdt_address_cells(fdt, 0); - int size_len = fdt_size_cells(fdt, 0); + int address_cells = fdt_address_cells(fdt, 0); + int size_cells = fdt_size_cells(fdt, 0); char *p = buf; for (i = 0; i < n; i++) { - if (address_len == 2) + if (address_cells == 2) *(fdt64_t *)p = cpu_to_fdt64(address[i]); else *(fdt32_t *)p = cpu_to_fdt32(address[i]); - p += address_len; + p += 4 * address_cells; - if (size_len == 2) + if (size_cells == 2) *(fdt64_t *)p = cpu_to_fdt64(size[i]); else *(fdt32_t *)p = cpu_to_fdt32(size[i]); - p += size_len; + p += 4 * size_cells; } return p - (char *)buf; |